Björn Rabenstein

Sounds promising. (Not that I would know a lot about this documentation.)

NHCB stuff needs to be added, too (working on it already).

With https://github.com/prometheus/prometheus/pull/14997 and https://github.com/prometheus/prometheus/pull/15135, there is only WAL and WBL left.

https://github.com/prometheus/prometheus/pull/15554 has added the WAL/WBL part.

Hello from the bug scrub! We found ourselves a bit puzzled if you really need a change. If you take `scrape_samples_post_metric_relabeling` and subtract `prometheus_tsdb_head_samples_appended_total `, you should get the part...

@amanycodes thank you for your interest. @ArthurSens @bwplotka maybe you could help out by telling us if the thoughts from the bug scrub go into the right direction. Should we...

Just saw a very similar race in a different test (TestTargetDisappearsAfterProviderRemoved): ``` ================== WARNING: DATA RACE Read at 0x00c00016caa0 by goroutine 700: github.com/prometheus/prometheus/scrape.(*scrapePool).sync() /__w/prometheus/prometheus/scrape/scrape.go:480 +0x18f github.com/prometheus/prometheus/scrape.(*scrapePool).Sync() /__w/prometheus/prometheus/scrape/scrape.go:463 +0x564 github.com/prometheus/prometheus/scrape.(*Manager).reload.func1() /__w/prometheus/prometheus/scrape/manager.go:202...

While discussing https://github.com/prometheus/prometheus/issues/13586, I suddenly remembered the implications for this issue. As we want to strictly require a selector to return only matching results, we _do_ have to do some...

Also, for labels that are involved in label matching (in aggregations, but even for binary operators), we need to do the rewriting in the result anyway, e.g. you have `foo...

Thanks for all the good arguments and findings here. It occurs to me now that this problem is way bigger than just exploding the queries. I would even argue that...