Björn Rabenstein

Results 1096 comments of Björn Rabenstein

To summarize the concerns about the operator syntax (see above, but also from personal communication): 1. `>` and ` 0.1` could be read as "return the histogram unchanged if it...

Some ideas: Maybe `/` would work? We are "slashing" the histogram, after all… "less-slash"/"greater-slash" even reads semi-nicely… If it helps, we could have just one operator, as the order can...

Yes, a word as an operator is also an option. To me, they kind of look weird (not just in this case). `and` and `or` are kind of "well known"...

This looks good in general, we "only" need to make a call how to name the operator. By now, I'm pretty sure we shouldn't use the `` directly, for all...

# Symbolic operator Histogram with only observations less or equal 2.5: ```PromQL request_duration_seconds:rate5m

# Word operator Histogram with only observations less or equal 2.5: ```PromQL request_duration_seconds:rate5m trim 2.5 ``` Histogram that excludes the bottom 10% and top 10% of observations: ```PromQL histogram_quantile(0.1, request_duration_seconds:rate5m)...

Thanks, @juliusv . That's a good point. I think given the different nature of the new operator, we _could_ introduce this different kind of behavior. It would be well defined,...

One argument is that it isn't comparing and it isn't filtering. It is removing observations from a histogram, returning a mutated histogram. That's kind-of the argument that @krajorama brought up:...

Related to this (but triggered by an unrelated issue), @krajorama, @zenador, and myself discussed @krajorama's earlier idea about giving the ``, `=` operators a useful behavior if applied to a...