Björn Rabenstein

Results 1096 comments of Björn Rabenstein

Just to clarify the nature of the boundaries in native histograms: The boundary that is farther away from zero is inclusive AKA closed, while the boundary that is closer to...

@hdost are you still working on this?

And @jan--f has already picked it up.

With no movement here in awhile, I assume the current state is good enough and close this.

Hmmm… first of all I would like to understand what's actually going wrong in the first case (where consistency checks _are_ enabled IIUC, and still the PGW reaches an inconsistent...

It's more complicated than that. It is very common that the body contains labels that should _not_ be part of the grouping key. This needed a different format in the...

> As a side note, there are valid cases for expiring keys. In this case, it is to follow the data from a vehicule. When the vehicule returns to the...

Sorry for sprinkling the comments instead of doing them in one review. But I think I have addressed all questions now.

The feature request is legitimate, but it depends on support in https://github.com/prometheus/common . The latter already has https://github.com/prometheus/common/blob/main/expfmt/openmetrics_create.go , which is used by client_golang to expose OpenMetrics (if so requested,...

So yeah, the base64 trick was introduced prior to 1.0.0. So we never had the situation where a PGW of v1+ would be confronted with a newer version of the...