Björn Rabenstein

Results 1096 comments of Björn Rabenstein

Fundamentally, I would say there must be a different code path in the PromQL engine for "sum the result of a function call" and "sum the result of a bin-op",...

We discussed on the chat-system-that-shall-not-be-named. I guess the most likely reason for this is what @bboreham said there: "At a high level, it’s likely that each new expression changes the...

@codesome (and maybe @bboreham ), we have run into this during the bug scrub, and it seems to us this is kind-of good to go. Would you agree? Of course,...

Hello from the bug scrub. This sounds useful to us, but nobody worked on it in 4y. @dgl can you confirm that this is still relevant and that we would...

I don't know of any other plans or people working on this. I'll assign this to you @szczepad . One more ping for @dgl in case there is something to...

Hello from the bug scrub. We have a hard time vetting the current relevance of this. @SuperQ @roidelapluie, as you commented before, do you think this should be kept open?...

I tried to reach @roidelapluie out of band. Let's wait for another day or so if he comes back to us with an explanation. Otherwise, we have to assume @bboreham...

Note for a future PR: It would be good to also be able to assert annotations.

I'm currently reviewing https://github.com/prometheus/prometheus/pull/13662/ (which @zenador mentioned above as another PR that needs assertions on returned errors (in this case annotations)). Since we use this for both the internal PromQL...

Note that https://github.com/prometheus/prometheus/blob/main/docs/configuration/unit_testing_rules.md needs to be updated with the changes here.