Björn Rabenstein
Björn Rabenstein
Thanks for all the discussion, which I try to follow and learn something… :sweat_smile: > Lets go with the parent BinOp as you suggested as the AST So that does...
Generally, this looks very nice. However, there is a nasty edge case: In rare cases, a counter reset could not be seen in the count but only in individual buckets....
> Let me take a look at how we can do the detection transparently in an efficient manner. In the worst case we will just store the last decoded histogram...
Another thought that crossed my mind: What about overlapping blocks and (soon) out-of-order handling? This might create a lot more cases where we set the counter reset hint to "unknown"....
Good luck with the move. Looking forward to further explorations into this issue.
Thank you very much. This is now very close to the top of my review queue, but I won't get to it this week. Sorry for that.
How does the benchmark look with the added storing of the last seen histogram?
I hope it's OK if I squash the commits into one…
Great stuff. I'll have a detailed look ASAP (which might be Tuesday). Thank you very much.
Sorry, drowning in work, it will take another day or so.