Björn Rabenstein
Björn Rabenstein
> As there are significant functional differences between v2 and v3, are there plans to continue maintaining v2 after v3 is released? When shall the life cycle of v2 end?...
I think I got all tests passing. Let's see if it goes green. If it does, please still double check my lookback delta changes. Then you only need to address...
> I noticed that `promql/engine_test.go` is constantly be changed, especially at the code blocks commented as `// TODO(.*): Integrate .* into the PromQL testing framework`. > > So how shall...
I'll do the final code level review of this PR ASAP.
In different news: The v3 coordinators will discuss cutting a release branch next week.
Documentation updates needed (probably not a complete list, just the locations I could find at a glance): Needs clarification that the lookback period excludes samples that are precisely 5m earlier...
Currently, the cleanest way is to encode SLO targets into the instrumented service binary itself and let it expose request counters for "SLO met" or "SLO missed". Of course, that...
Just checking (because issue is not resloved yet): @juliusv you are aware that you will be our Python expert tomorrow, aren't you?
I really don't remember the detailed motivations here, just that it was complicated. Maybe the problems you have encountered above have to do with the reason.
It's not so much the grouping or the join that creates these artifacts, but the multiplication. At least I can create [the same "noisy" heatmap by multiplying with a `1`...