Ben Vanik

Results 416 comments of Ben Vanik

we should have a meeting - hard to work through on an issue :) DumpExecutableBenchmarks shows how to manually build HAL stuff - that's what'd be easiest here. For switching...

`git add . --renormalize` fixes line ending stuff for me whenever I have issues - maybe could run that after (git line ending handling confuses me, so I use `python...

Yeah, lots tangled up here - we'll need to break it down. There's some easier solutions and some harder ones for sure :) I suspect we'll build ArgumentBuffer-like thing in...

(this was how I was imagining enabling secondary command buffer buffer substitution in iree_hal_command_buffer_execute - so doing it may get us that too!)

Took a look at what would be needed. @antiagainst articulated the major parts and then there's a few details: * need to do #7824 so that we can have alternative...

Oh the other thing this intersects with is secondary indirect command buffers (`iree_hal_command_buffer_execute_commands`) - those are recorded with placeholders and then when executed the placeholders get updated to the bindings...

One thing that may need some fiddling is how to communicate the pipeline layout mode or if we want to make it per descriptor set (I think we want to...

#14777 has disabled VMA by default and hopefully it sticks (there may be some issues). We'll let that soak a bit and get into shark before fully removing VMA. After...

Following up from the discussions yesterday, here's the spec I'm going to be shooting for on the compiler/runtime side outside of codegen: * new `HAL_DescriptorSetLayoutFlags_Indirect`/`IREE_HAL_DESCRIPTOR_SET_LAYOUT_FLAG_INDIRECT` flag * new temporary global...