benoit74

Results 1991 comments of benoit74

@Popolechien this is what we've discussed ATM for your record

I propose that we: - store in DB at task level if upload of logs or upload of artifacts failed - (confirm that we) store in DB at file level...

I've started work in https://github.com/openzim/gutenberg/tree/check-i18n but it showed that many keys seems to now be unused. Kinda a mess to clean-up, at least more than I can devote to this...

Let's start by adding a free text comment next to each blob, editable / viewable from the UI This is in fact mandatory before we can apply https://github.com/openzim/zimfarm/issues/1590 / https://github.com/openzim/zimfarm/pull/1599

I'm not sure I get when this error happens. Can you isolate a small code snippet showing when this error happens and why it is safe to ignore them? Would...

Wouldn't it be possible to have something like this: ```python if skip_validation: with warnings.catch_warnings(): warnings.filterwarnings( "ignore", message=r"PydanticSerializationUnexpectedValue", category=UserWarning, ) return model.model_construct(**data) else: return model.model_validate(data, context={"skip_validation": skip_validation}) ```

Could it be because the warning is not raised here but somewhere else (when we serialize to DB)?

A first glance at the topic made me have the same opinion as @rgaudin ; but I felt a bit bad to have this warning forever, so I was unsure...

I don't expect it will not work the same way as WP1. In WP1, unless I'm mistaken, auth is handled in the Flask backend, not in the Vue 2 frontend....