Ben McCann

Results 1466 comments of Ben McCann

The reason SvelteKit does prerendering in a subprocess is so that we can call `process.exit` to ensure it's fully killed (e.g. to support cases where the user's app does something...

> SvelteKit, the framework, relies on other Svelte language tools that are not fully compatible with Deno, such as the Svelte LSP which is built for the Node.js toolchain I...

The last issue I know about was fixed in SvelteKit 1.17.0: https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md#1170 Are there any issues remaining or can this issue be closed now?

I took a look at this and overall it's quite nice as it removes the need to do `.data` on every response. The trickiest thing is figuring out how to...

I migrated the CLI from the `typescript-axios` to `typescript-fetch`, but which removed the axios dependency. However, I saw that unused API methods weren't being tree shaken out, so switched to...

looks like there's a handful of merge conflicts here now

These generally seem like good changes to me. I wonder if it might be easier to review if split up into separate PRs. The main question I would have is...

Setting up publint for the package would also catch this. For example: - https://publint.dev/@rollup/[email protected] - https://publint.dev/@rollup/[email protected]

The build was failing with a message that looked like it was because it was out of sync with `master`, so I updated it to the latest `master`. It's now...

@tanhauhau shared some notes with me. Putting them here for reference for kit issue, it's because of code like this: ``` let components = [Layout, Route]; {#if components[1]} {#if components[2]}...