Ben McCann

Results 1639 comments of Ben McCann

I was looking at the code and noticed some style issues such as a mix of tabs and spaces. Could you setup the Chart.js style rules before we merge it?...

Ok, thanks, Scott. Since you're open to contributing the code, anyone from the community should be able to grab the code from your repo, clean it up a bit, and...

This would be fixed by using Scott's code, which supports Chart.js v2: https://github.com/scottmcculloch/Chart.LinearGauge.js

+1. You just just need to do something like `![BarFunnel Example Image](barfunnel.png)`

I fixed one and asked about the other https://github.com/AbelHeinsbroek/chartjs-plugin-crosshair/issues/85

Looks like there's a v3 branch, but they've been slow to update things: https://github.com/AbelHeinsbroek/chartjs-plugin-crosshair/pull/65#issuecomment-872903672. I'll ask for an update there

That sounds fine to me

This project requires Chart.js 3.0. I wonder if you're using Chart.js 2.x?

https://github.com/chartjs/chartjs-chart-financial/blob/f10c04641fe20860cf5070fcd3788f134ea22a4f/package.json#L18

Thanks for sharing this! I'm pretty busy at the moment working on fixes and improvements in the main Chart.js repo in order to improve the finance chart, so it may...