benma

Results 434 comments of benma

Please ask all your favorite wallets to add BitBox02 support. Eternl said it was on their list, but it can't hurt to make your voice heard to help them prioritize...

> > I did some research and I think that mac os is getting stricter with unsigned software, and we should probably sign the artifacts in the CI flow >...

The AndroidManifest only specifies dataSync, so maybe on Android 34, the deviceConnected one is not actually in use? With this commit, on Android 34 both types would be specified in...

fyi @achow101, I reviewed this before @asi345 made the PR

@achow101 please approve the workflow and take another look at the changes, would be really nice to have this merged soon. Thanks!

> The current implementation is causing all other tests to fail. @achow101 please take a look again, @asi345 updated the PR and all checks have passed.

@achow101 ping again - it's so close :nerd_face: :smile: would be great to merge this.

Great! > Regarding attribution/license, how would you like us to proceed? Since your repo doesn't have a license. Would it be okay if the PR that adds your code would...

@Roasbeef it would be great avoid generics until https://github.com/gopherjs/gopherjs/issues/1013 is resolved - we use GopherJS to compile a library making use of btcd to JS. Should even consider sticking to...

@kcalvinalvin > (All things aside) what was the thing you were trying to do? Maybe I could help out there. We are using it in a few projects and I...