HWI icon indicating copy to clipboard operation
HWI copied to clipboard

Add BitBox02 Simulator

Open asi345 opened this issue 1 year ago • 8 comments

Recently, a simulator for BitBox02 was implemented. Therefore, we also wanted to add this to HWI repository for automated tests and ease of reference in the future.

asi345 avatar Jun 05 '24 21:06 asi345

fyi @achow101, I reviewed this before @asi345 made the PR

benma avatar Jun 06 '24 12:06 benma

Okay, we also came up with a solution for docker in docker problem for bitbox02 simulator. Now, a separate build_bitbox02.sh script is ran before running hwi container, to build BitBox02 simulator. See the comments in ci Dockerfile for reference.

asi345 avatar Jul 17 '24 17:07 asi345

@achow101 please approve the workflow and take another look at the changes, would be really nice to have this merged soon. Thanks!

benma avatar Aug 22 '24 12:08 benma

Could you rebase so that CI runs the tests with the simulator?

achow101 avatar Aug 30 '24 17:08 achow101

Okay, I rebased this branch on top of master. CI is again waiting for your approval.

However, can you in any chance fix bitcoind build first? This commit breaks bitcoind build in setup_environment.sh, since autogen.sh file is not existent in bitcoin repo anymore : https://github.com/bitcoin/bitcoin/commit/d71ac768424333b65a6d88c9752cc9c7fdb276f3

asi345 avatar Sep 04 '24 08:09 asi345

However, can you in any chance fix bitcoind build first? This commit breaks bitcoind build in setup_environment.sh, since autogen.sh file is not existent in bitcoin repo anymore : https://github.com/bitcoin/bitcoin/commit/d71ac768424333b65a6d88c9752cc9c7fdb276f3

See https://github.com/bitcoin-core/HWI/pull/752

brunoerg avatar Sep 04 '24 09:09 brunoerg

The current implementation is causing all other tests to fail.

achow101 avatar Sep 12 '24 14:09 achow101

I updated the commit to handle connection refused on BitBox02 simulator, now it seems that other devices do not fail.

asi345 avatar Sep 25 '24 14:09 asi345

The current implementation is causing all other tests to fail.

@achow101 please take a look again, @asi345 updated the PR and all checks have passed.

benma avatar Oct 28 '24 18:10 benma

@achow101 ping again - it's so close :nerd_face: :smile: would be great to merge this.

benma avatar Nov 27 '24 08:11 benma

ACK 3c3a185200fb92281128d0d84e0697da21f7dc09

achow101 avatar Dec 04 '24 20:12 achow101