benma

Results 434 comments of benma

@thisconnect actually it was a different error, some transient backend/handler test failed for some reason. Re-run was successful.

This currently adds 9228 bytes to the binary, luckily less than this PR saves :smile: https://github.com/BitBoxSwiss/bitbox02-firmware/pull/1215

Rebased. Need to double-check if payment requests to silent payment addresses work safely (an output that is both attached to a payment request and is generated by a SP address)...

Host side that verifies the generated output correctness using the DLEQ proof and returns them: https://github.com/BitBoxSwiss/bitbox02-api-go/pull/105 This includes a simulator test the complete integration is tested.

@NickeZ one way to test it (except the integration/unit tests included in this PR) is an integration test on the host side with the simulator: ./scripts/docker_exec.sh make -j simulator Then...

> Also, I don't understand why CI fails It's because our clang-tidy check runs only on the files that are in the diff, which in this case is sdcard.c. Please...

There's been a lot of small such contributions lately, and often the same changes to many repos. Out of curiosity, what's the motivation? Is there some sort reward for GH...