benma

Results 434 comments of benma

> opened so I don't forget but need to test this more. fyi, you can use 'Draft' instead of PR when a PR is not ready

I think some versions were already updated again, such as `node_modules/@babel/helper-compilation-targets`. Maybe rebase and do it again? Speaking of ` --ignore-scripts` - also in our Makefile in `make buildweb`? Didn't...

> @Beerosagos that means ACK? smile (the Restore thing is a separate issue imo)

If you select BTC as the "fiat" currency, all the BTC formatted there are not formatted as satoshi's currently, but probably should. Example: ![image](https://user-images.githubusercontent.com/1225267/193020565-62a8a476-1e84-4d33-9edb-86453bc32016.png)

> an alternative could be to keep BTC as base currency and add "sat" as another base currency (but I guess that would be a different PR).. > > >...

> By the way, is there a reason why this uses S2C instead of simple addition I did it this way for two reasons: - sign-to-contract seems useful also for...

> > About s390x: I am puzzled, I don't see anything related to endianness in the code related to the failing test, but maybe I am missing something. I also...

Most of the commits are taken as-is from @jonasnick and @apoelstra, with the added exfil functions working the same way as in the ECDSA version in [secp256k1-zpk](https://github.com/ElementsProject/secp256k1-zkp/tree/master/src/modules/ecdsa_s2c). It would be...

Thanks. > This should reduce the install time for the image a little bit & reduce the image size. Can you quantify that? What's the difference in size and build...