benma

Results 434 comments of benma

There is no need to remove support for `xpub ypub zpub`, but it would help to also parse descriptors additionally. Electrum will likely use descriptors as well, at least for...

> Thinking about this some more. I think this could be most useful for restoring from old backups without waiting for a rescan. :+1: It's fine if this command is...

That would be a good start. How would the proposed workflow be from a client to add an xpub? If EPS doesn't expose an API call, another sort of service...

Agreed. Maybe one option is to extend the electrum protocol with new api endpoints (prefixed with `eps` or similar to keep namespaces separate from the other electrum endpoints), then the...

for golang/protobuf, apart from the json issue mention above, there are the following other issues: ``` ../../vendor/github.com/golang/protobuf/proto/extensions.go:62:46: Locker not declared by package sync ../../vendor/github.com/golang/protobuf/proto/extensions.go:82:71: Locker not declared by package sync...

Any update on this? My string is around 100 chars long and rustfmt does not format it nor the surrounding code (other fields in the struct besides the one with...

It seems the surrounding code around a long string is also not formatted. This struct instance for example is not formatted at all: ```Rust fn main() { struct Foo {...

I don't think you intended to make 6 commits :grin: try squashing them into 1 commit and putting the PR description into the commit msg. Let me know if you...

> Should I add a button to bypass Tor proxy when connecting to a custom block explorer, or leave it hard-coded? What do you mean exactly? Block explorer links are...

Sneak preview looks great :+1: there are block explorer links also for testnet and altcoins. Not sure what to do with those. Maybe just label it 'Custom Bitcoin block explorer'?