bitbox-wallet-app icon indicating copy to clipboard operation
bitbox-wallet-app copied to clipboard

frontend: enable sats unit option for bitcoin accounts

Open Beerosagos opened this issue 3 years ago • 3 comments

The main unit displayed in the app for bitcoin accounts is Bitcoin (BTC), but sometimes it can be easier to think in terms of Satoshi (SATS), especially for lower amounts.

This allows the user to choose the preferred unit using a switch in the expert settings section of the frontend.

Beerosagos avatar Sep 20 '22 15:09 Beerosagos

If you select BTC as the "fiat" currency, all the BTC formatted there are not formatted as satoshi's currently, but probably should. Example:

image

benma avatar Sep 29 '22 11:09 benma

an alternative could be to keep BTC as base currency and add "sat" as another base currency (but I guess that would be a different PR)..

If you select BTC as the "fiat" currency, all the BTC formatted there are not formatted as satoshi's currently, but probably should.

thisconnect avatar Sep 29 '22 11:09 thisconnect

an alternative could be to keep BTC as base currency and add "sat" as another base currency (but I guess that would be a different PR)..

If you select BTC as the "fiat" currency, all the BTC formatted there are not formatted as satoshi's currently, but probably should.

I think we discussed and dismissed this idea before. Sat is not a currency but a unit. You also don't want to see 'Sat' as a currency conversion in say an Ethereum account.

benma avatar Sep 29 '22 11:09 benma

Pushed an update, but just found a bug. Converting to draft until it is fixed

Beerosagos avatar Oct 20 '22 13:10 Beerosagos

Bug should be fixed: it was failing to retrieve erc20 coins in getConvertToPlainFiatHandler. PR Re-opened and ready for a new round of review :+1:

Beerosagos avatar Oct 20 '22 13:10 Beerosagos