bitbox-wallet-app icon indicating copy to clipboard operation
bitbox-wallet-app copied to clipboard

frontends\web\src: color variables refactoring

Open jadzeidan opened this issue 3 years ago • 2 comments

Seperated text and background colors into their own variables. This makes colors easier to maintain because now it's possible to change text and background colors without affecting each other.

Also some text used --soft-black instead of a designated /* font colors */ variable. Changed this text to --color-default so it is consistant with the other text colors.

jadzeidan avatar Oct 03 '22 15:10 jadzeidan

I don't think you intended to make 6 commits :grin: try squashing them into 1 commit and putting the PR description into the commit msg. Let me know if you need help with that.

Also, frontend: is good enough for the commit title prefix. It is meant to convey the context and doesn't need to be an exact path or anything.

benma avatar Oct 03 '22 18:10 benma

I don't think you intended to make 6 commits 😁 try squashing them into 1 commit and putting the PR description into the commit msg. Let me know if you need help with that.

I'm trying to squash but it's multiplying 😭

Edit: figured it out now :)

jadzeidan avatar Oct 03 '22 19:10 jadzeidan

@thisconnect I think I addressed all the comments. PTAL

jadzeidan avatar Nov 01 '22 11:11 jadzeidan