Ben Keith
Ben Keith
I ran across a scenario today where https://github.com/Automattic/Co-Authors-Plus/pull/696 would have been very helpful if it were in the plugin. What's needed to get that PR across the finish line?
I assume so, but I'm not an owner of this repository.
The test seems to think that this use: https://github.com/hamcrest/hamcrest-php/blob/8c3d0a3f6af734494ad8f6fbbee0ba92422859f3/tests/Hamcrest/Type/IsNumericTest.php#L28-L29 is a use of hex strings in a function which isn't known to support them: https://github.com/PHPCompatibility/PHPCompatibility/blob/5c6bf16595c0f5ecd3df28f37d9aa7c4df66524c/PHPCompatibility/Sniffs/Numbers/RemovedHexadecimalNumericStringsSniff.php#L40-L102 The inconsistent behavior before PHP...
As written, yes, this seems like a false positive, but it's alerted us to a deeper problem: Using [`wp shell`](https://developer.wordpress.org/cli/commands/shell) as a REPL under PHP 7.3: ``` wp> is_numeric( '0'...
Yes, that's what the method does. I'm calling into doubt whether that is the correct approach. Should this package reply "yes, it is numeric" if the language says "no, it...
Long link and long title do go hand in hand for testing of overflow content. It would also need a long excerpt, a long category, and a long tag.
I'm no longer a maintainer on this project, so the folks at Automattic can overrule me on this, but: In `js/pym.js`, you do change one `http` to `https`, but you...
This patch looks much cleaner now; thank you!
Hi Elise; thanks for reporting this issue. Can you tell us: - the version of PHP you're using - the version of WordPress you're using - the version of the...
> I'm running version 4.9.9 of WordPress. If the theme I'm now using is fresh, then I'm assuming the php version is much newer as well. That's not necessarily the...