pym-shortcode icon indicating copy to clipboard operation
pym-shortcode copied to clipboard

Fix http strings to https where possible

Open hassanelnajjar opened this issue 4 years ago • 3 comments

search for http: and check the url using chrome and then change the secure url to https

relates #73

Changes

This pull request makes the following changes:

search for http: and check the url using chrome and then change the secure url to https

Why

For #

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

  • [x] Is this PR targeting the correct branch in this repository?
  • [x] Does this work for the test cases provided in https://github.com/INN/pym-shortcode/blob/master/docs/maintainer-notes.md#testing-before-release ?
  • [ ]

Steps to test this PR:

Additional information

INN Member/Labs Client requesting: (if applicable)

  • [x] Contributor has read INN's GitHub code of conduct
  • [x] Contributor would like to be mentioned in the release notes as: (fill in this blank)
  • [x] Contributor agrees to the license terms of this repository.

hassanelnajjar avatar Jun 12 '21 20:06 hassanelnajjar

I'm no longer a maintainer on this project, so the folks at Automattic can overrule me on this, but:

In js/pym.js, you do change one http to https, but you also changed the whitespace and formatting of the entire file. That's not optimal, especially since js/pym.js is a file that was copied in directly from a third party. Can you revert the whitespace changes, please?

benlk avatar Jun 14 '21 14:06 benlk

I'm no longer a maintainer on this project, so the folks at Automattic can overrule me on this, but:

In js/pym.js, you do change one http to https, but you also changed the whitespace and formatting of the entire file. That's not optimal, especially since js/pym.js is a file that was copied in directly from a third party. Can you revert the whitespace changes, please?

I fixed the white spaces :)

hassanelnajjar avatar Jun 14 '21 15:06 hassanelnajjar

This patch looks much cleaner now; thank you!

benlk avatar Jun 14 '21 18:06 benlk