Ben Keith
Ben Keith
That information is all useful to us; thank you. If you go to https://ni4kids.com/?google_force_console=1, the [Google Publisher Console](https://support.google.com/admanager/answer/2462712?visit_id=636776405597964604-1318369320&hl=en&rd=2) should appear on your site. In it, there'll be an item for...
That's disturbing. If you copy the plugin from the functional site to the broken site, does that work?
(she said yes, in a helpscout email.) But someone else has reported this, *not* using the widget but using the `$doubleclick->place_ad()` function inheriting from `global $doubleclick`, which used `global $DoubleClick`...
Other thoughts on the subject: https://10up.com/blog/2017/ads-in-a-gutenberg-world/
This may be related to #91 and #90. Next steps: - [ ] compare with #90 to see if the ad unit sizes are off - [ ] check to...
- [ ] Does `window.dfw` have a value at the time the ads are loaded? May need to put that localization into the header instead of the footer. https://secure.helpscout.net/conversation/765188412/3113/?folderId=1219602 -...
Aha. https://github.com/INN/doubleclick-for-wp/blob/f73e00d5cf8897fd75706453986b21a0e6e4a8a2/inc/class-doubleclick.php#L159-L163 `window.dfw` uses `targeting` and `mappings`; the added code uses `setTargeting` and `sizeMapping`. - [ ] Add those terms. That might reduce the amount of code needed on https://github.com/INN/doubleclick-for-wp/blob/bf4fcb5423ff359af955948ba253a8e2211185a3/js/jquery.dfw.js#L35-L39
This: - ❌ adds a lot of boilerplate files - ❓ deletes the docs? - 😬 refactors the plugin - 😕 adds tests for widgets and settings, which are dependent...
This PR may also address the following issues: - https://github.com/INN/doubleclick-for-wp/issues/90 - https://wordpress.org/support/topic/do-not-use-version-0-3/ - https://github.com/INN/doubleclick-for-wp/issues/92
Test release of this plugin created: https://github.com/INN/doubleclick-for-wp/archive/v0.3.1-rc1.zip Submitted to that one wp.org user for testing: https://wordpress.org/support/topic/do-not-use-version-0-3/#post-11181996