Ben Keith
Ben Keith
Items to copy from the client project: - [ ] changes to `Video - [ ] and `VideoControl` - [ ] `PosterControl` - [ ] updated PHP partial - [...
If we have an `Image` for ``, why not call the new `` component `Figure`?
Status update: doing a bunch of code review revisions over on the project that I built this for; will open a PR here when that's approved.
PR added, with questions: https://github.com/10up/block-components/pull/225
I asked VIP, and this is what [their support agent said](https://support.wpvip.com/hc/en-us/requests/175100?page=1): > Yes, the default post password function included in WordPress works as expected on VIP, as it sets a...
> And for the purposes of CI systems, we don't want a scenario of "is up-to-date, all good" to throw an error and stop the pipeline. This might be behavior...
This may be state-specific, bake-specific data. How would you like to organize this?
That makes sense. After skimming through the docs, the most-likely-looking place to add this is https://github.com/openelections/docs/blob/master/dataentry.md#instructions, but that's not likely to be someplace where people who are using your data...
How do you want to handle writing definitions for http://docs.openelections.net/common-fields/ ?
I confirm this bug as well. I _think_ the error is here but will need to test next week: https://github.com/10up/safe-redirect-manager/blob/cb1c04513b75736a0938208c5837b3ce51abdcba/inc/classes/class-srm-redirect.php#L225-L229