block-components icon indicating copy to clipboard operation
block-components copied to clipboard
verified publisher icon 10up

Component: Video

Open benlk opened this issue 2 years ago • 3 comments

Is your enhancement related to a problem? Please describe.

We have an Image component that provides a way to upload an image, show it, and handle placeholders if no image has been uploaded.

Can we get the same thing for video content?

(Yes, it's often better to use an third-party embed for video content, but some client requirements sometimes require uploads direct to WordPress)

Designs

No response

Describe alternatives you've considered

I'll be writing an attempt at this for a client project, and will provide that as a PR for this project.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

benlk avatar May 23 '23 16:05 benlk

Looking forward to your PR :)

fabiankaegy avatar May 24 '23 11:05 fabiankaegy

Status update: doing a bunch of code review revisions over on the project that I built this for; will open a PR here when that's approved.

benlk avatar Jun 01 '23 17:06 benlk

PR added, with questions: https://github.com/10up/block-components/pull/225

benlk avatar Jun 02 '23 16:06 benlk