Ben Lesh comments

Results 270 comments of


                                            Ben Lesh

nf-graph: better behavior when setting yMin, yMax to null

@jamesarosen can you rebase? I've made some changes in this area.

maxProperty doesn't have a good way to use "default"

This is tricky. It seems like a few cases are not covered: - `null` - `undefined` - `NaN` - `Infinity` I think the behavior you're suggesting is perfect for `undefined`,...

maxProperty doesn't have a good way to use "default"

.. and on the `Infinity` side, I think that's an extreme edge case, but I can probably default that to MAX_VALUE or MIN_VALUE depending on the polarity of the thing.

maxProperty doesn't have a good way to use "default"

It's tricky. I sort of view the value the graph was _initially_ set with to be the "default", not necessarily the _coded_ default. It seems like we could memoize that...

maxProperty doesn't have a good way to use "default"

It should behave the same as a 0, I think.

maxProperty doesn't have a good way to use "default"

I really depends on the `yMaxMode` how it will behave. If it's `auto` it should ignore setting the value entirely.

maxProperty doesn't have a good way to use "default"

different `yMaxModes`: - `auto`: automatically calculate `yMax` from contained graphics' data - `push`: allow setting of `yMax`, but push the `yMax` value up if the contained data passes it. -...

maxProperty doesn't have a good way to use "default"

The method that is going to give you the most control will be using `fixed` in most cases. `auto` and `push` or `push-tick` were really added as conveniences, but might...

maxProperty doesn't have a good way to use "default"

> but might not be doing the most efficient thing when trying to suss out where your min and max values lie. For example, maybe your array is already sorted,...

contentClipPathId doesn't work on apps with <base> tag

FWIW, the clip path stuff is likely cruft.