Benjie

Results 1618 comments of Benjie

@graphql/tsc This PR extends the non-normative note about resolvers being asynchronous to also note that each entry in a list returned from a resolver can itself be asynchronous. Please either...

@graphql/tsc I would love to get your input on this change.

Hopefully my latest edit factors in @andimarek and @martinbonnin's feedback.

Try setting `preset.gather.pgIdentifiers`: ```ts const preset = { // ... gather: { pgIdentifiers: "unqualified", }, }; ```

Hi @hchatel; it is indeed a V5 feature, V4 doesn't have this capability. V5 splits the schema build into two phases: gather and schema; gather goes and figures out all...

That's interesting; I think the issue you're facing here is specifically because you're using an array. I think if you used an object instead, then it would work just fine...

On second thoughts... It could be that your scalar has no implementation so it's using a default implementation. You need to implement `parseLiteral`, etc - see the GraphQLJSON scalar for...

I don't think it's necessary but nonetheless I've changed it to "if and when" to make clear both the conditional ("if") and timely ("when") elements. I'd argue `thing.on('error', e =>...

This was later spotted by @Yogu and their fix has since been merged; so this PR is no longer needed. Ref: https://github.com/graphql/graphql-spec/pull/994

The main thing when doing this is to ensure that the `fastifyv5` request context entry is registered; it should look like: https://github.com/graphile/crystal/blob/19420562a3d7b49e3cde8f4ff0ece5b8286e43d8/grafast/grafserv/src/servers/fastify/v4/index.ts#L28-L37 You code should **not** `import` from `fastify` at...