Benjie

Results 1475 comments of Benjie

That makes sense; `extend type Query` on it's own would be as meaningless (no-op) as `extend type Query {}`. Trailing commas are an interesting analogy; all commas are ignored in...

Things to check that I actually implemented (from my notes): - [x] Nudge on new job notification. - [x] Must release jobs in the queue if held for greater than...

To enable feedback on this PR, I've released it as a canary; install via `graphile-worker@canary`. Please note that this PR does not have tests or documentation, so I would not...

Thanks for the report of the crash! There's clearly an issue preventing the tests from reliably passing too, I suspect some kind of race condition has slipped in. Did these...

@hillac I've fixed that line by adding a `?` - you're right that there's nothing forcing the rejection reason to be an object/error. (This may well be an issue that...

> stack trace has the line number, worker.js:222:43 I read `worker.js` as `main.js` again :man_facepalming: I definitely need more sleep! :sleeping:

Hooray; seems that the instability in this PR was actually in the test framework rather than Worker itself. 4 passes in a row suggests I have stabilized this now, plus...

Latest canary released: `[email protected]` I've extracted the following PRs from this PR so that it's simpler to review: - #506 - #507

The latest canary is out and it contains a number of fixes to other parts of Worker.

Error handling needs testing, in particular I'm not sure we have any tests that touch `returnJobs`