Benjie

Results 1487 comments of Benjie

With a little guidance, codex believes it has spotted the issue; this sounds plausible: > GraphiQL itself is manufacturing that { "errors": [...] } string. In node_modules/@graphiql/react/dist/stores/execution.js:105-234 the execution slice...

My guess at the moment is that when Apollo Client passes the fragments through, they're not the same objects for some reason. Potentially it's doing the `__typename` transform each time?...

Here's where the fragments are checked: https://github.com/graphile/crystal/blob/990e7ebcb82f319d3caadef635c7a00cdce7ee5e/grafast/grafast/src/establishOperationPlan.ts#L41-L57

This was merged into #1039 and since merged into the spec.

I _think_ this is good to go now. Ideally someone would go through each of the existing /graphql-js/* pages and check they redirect to a sensible place, but... 🤷‍♂

Deleting the folder seems to be insufficient; certain links do not function now - e.g. "GraphQL.JS Tutorial" in the header. It's possible all the relative links to `/graphql-js` will not...

Hi @bbaustin please can you provide more details: exactly what browser versions and operating system are you using? Have you tried incognito/private window with all extensions disabled? I see no...

I'm generally supportive of adding `@deprecated` to more locations, but proposing additional locations for `@deprecated` should be done through separate issues/PRs/RFCs (ideally one PR per location to keep the discussion...

Please keep this stream of consciousness going as you explore the docs, it's valuable insight for us :raised_hands: