Ben Lambert

Results 637 comments of Ben Lambert

@QuadmanSWE thanks for the issue. You're 100% right, let's update that. Do you wanna raise a PR for a contribution here? :pray:

For sure! I think that it makes sense to update any of the references to `master` especially in the case of newly creating things like new repositories to be `main`....

Hmm - yep, seems sane. Wonder if we should be moving to a `${{ context.task.id }}` or something, needs some thought I think. @acierto?

@hubofgitongithub unfortunately there's no workaround, it's not available in context yet. Do you want to raise a PR adding the `${{ context.task.id }}` property to the templating context @hubofgitongithub? :pray:

Sorry for the delay here, but I think that this should be relatively simple: You have the `taskId` here: https://github.com/backstage/backstage/blob/8db9fdfc625338c29433a39f25347646335ab554/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts#L463 Here's where the `context` is created: https://github.com/backstage/backstage/blob/8db9fdfc625338c29433a39f25347646335ab554/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts#L484-L488 So that should...

You also have something similar in the action context already https://github.com/backstage/backstage/blob/8743beff4d843cc0fe0896a04407369f2db5c902/plugins/scaffolder-common/src/TaskSpec.ts#L39 However this only returns `entity.metadata` and not the full object. Perhaps that this could be extended to include the...

@camilaibs is this something you might want to look at with the new field explorer and see if this something that is easily fixable :pray:

@benjidotsh can you try out the bitbucket changes here to make sure things look good for you too?