Benjamin Huo
Benjamin Huo
> Would it be better to not include the `Revision.ImageDigest` when calculating the serving hash? > > ```go > func (r *FunctionReconciler) createServingSpec(fn *openfunction.Function) openfunction.ServingSpec { > if fn.Spec.Serving ==...
好的，多谢提醒。我们会报名！
@wanjunlei are we able to add labels to tekton step pods by adding labels to shipwright CRD?
@wanjunlei @wrongerror 我们测过 workload 为 job 的异步任务吗？workload 为 deployment 的异步任务是没有超时的我记得
> kind: Function > metadata: > name: function-sample > spec: > version: "v2.0.0" > image: "registry.cn-hangzhou.aliyuncs.com/xiaoming111/sample-go-func:v1" > imageCredentials: > name: push-secret > build: > builder: registry.cn-hangzhou.aliyuncs.com/xiaoming111/builder-go:latest > env: > FUNC_NAME:...
The e2e test has know issues which is still failing, it's ok not to fix it now. But it's better to fix https://github.com/OpenFunction/OpenFunction/actions/runs/6109785188/job/16581498056?pr=490 maybe :) @Bryce-huang
@Bryce-huang Is this ready for review?
> > @Bryce-huang Is this ready for review? > > Yes,I'm also doing tests. @wrongerror @wanjunlei @tpiperatgod @lizzzcai would you help to review this?
I would suggest the following changes: @Bryce-huang @wrongerror @wanjunlei @tpiperatgod @lizzzcai what do you think? ```yaml apiVersion: core.openfunction.io/v1beta2 kind: Function metadata: name: test-server spec: rolloutStrategy: canary: steps: - weight: 20...