Benjamin Huo

Results 373 comments of Benjamin Huo

@Gentleelephant will work on this issue

@koenekle Thanks for your contribution. If I understand the [alias]([alias feature](https://docs.fluentbit.io/manual/administration/monitoring#configuring-aliases)) correctly, it is for input and output plugins only and it's not for filter plugins: ![image](https://user-images.githubusercontent.com/18525465/185784160-401c82da-8b93-4cd2-b0fe-389d1094d47a.png)

After you add an alias for the throttle filter, what's the effect of this alias? The docs says the input/output plugin's alias is for metrics purpose.

@frankgreco Thanks for reporting this, and we'll take a look at this

> 1.7 and 1.8 are already EOL, I like the suggestion of KeyDoesNotExistLegacy or an alternative. Do we need to raise in Fluent Bit main repo? The Condition.KeyDoesNotExist has been...

We're going to release 1.10

@frankgreco we might need to add CRD conversion for changes like this https://book.kubebuilder.io/multiversion-tutorial/conversion-concepts.html https://book.kubebuilder.io/multiversion-tutorial/conversion.html if there're quite a lot changes like this. An example is here https://github.com/OpenFunction/OpenFunction/blob/main/apis/core/v1alpha2/function_webhook.go https://github.com/OpenFunction/OpenFunction/blob/main/apis/core/v1alpha2/function_conversion.go I mean...

@frankgreco the current k8s log processing pipeline doesn't use this functionality of the modify filter plugin and we haven't received an issue-reporting of his bug(The current FB version is v1.8.x+,...

OK, I understood your concern now. Let's revert this PR and prepare to upgrade the CRD version and add CRD conversion to it.