Results 14 comments of Ben Hutton

yes! I was about to submit a request for the exact same feature. I want the first one or two or N retries to NOT send anything to sentry, because...

:+1: for shipping 1.0.0 Doing our weekly `bundle update` on our app... This 0.10.5 -> 0.10.6 upgrade is causing me much more grief than the rspec 3.6 upgrade.

@bf4 2 things: 1. https://github.com/rails-api/active_model_serializers/pull/2119 caused our tests that leveraged unpersisted (for speed) `ActiveRecord` objects to fail (since they don't have an `id`) 2. For whatever reason, before this release...

@bf4 wrt semver..... When the README says that this project adheres to semver, what about semver is it currently adhering to? Or should the README be updated to say something...

@apotheon it looks like the other `require` line came in through https://github.com/carmen-ruby/carmen/commit/5d456f56e0bf528bac9600cc950c773db465a3d7. Some of that code is still in use today. `require 'active_support'` doesn't actually require any of the libraries...

@apotheon I definitely don't know this codebase at all! Sorry

I believe that the fix needs to be made in this gem. Before [this line](https://github.com/desiringgod/api/blob/master/spec/spec_helper.rb#L20) there should be a `require 'active_support'`. Here is the relevant context: https://github.com/rails/rails/pull/43852#issuecomment-992674343. Apparently (and this...

And actually, it looks like, if you add in any attributes, you lose option 4, and so option 2 is the only valid one: ``` > Redcarpet::Markdown.new(Redcarpet::Render::HTML).render(%()) => "\n" >...

And unfortunately, that is invalid html5: ``` Test ``` Run that through https://validator.w3.org/#validate_by_input ![image](https://cloud.githubusercontent.com/assets/61645/21568585/bc12d670-ce83-11e6-911a-c88ffe61be77.png)