carmen icon indicating copy to clipboard operation
carmen copied to clipboard

Published 20 hours ago • verified publisher icon carmen-ruby

Require ActiveSupport

Open benhutton opened this issue 3 years ago • 4 comments

This fixes #297.

benhutton avatar Jan 31 '22 18:01 benhutton

@apotheon it looks like the other require line came in through https://github.com/carmen-ruby/carmen/commit/5d456f56e0bf528bac9600cc950c773db465a3d7. Some of that code is still in use today.

require 'active_support' doesn't actually require any of the libraries inside of AS. You still need to do that individually. require 'active_support' is basically setup code. See https://guides.rubyonrails.org/active_support_core_extensions.html#stand-alone-active-support for more details!

benhutton avatar Feb 22 '22 21:02 benhutton

Thanks. I stand corrected regarding the other require.

apotheon avatar Feb 23 '22 08:02 apotheon

@benhutton - How do you feel about maintaining a fork and pulling in code from pull requests already submitted as needed? Perhaps name it "SanDiego" and publish it as a gem. That's assuming you know the codebase well enough and have time to be a maintainer.

apotheon avatar Mar 04 '22 21:03 apotheon

@apotheon I definitely don't know this codebase at all! Sorry

benhutton avatar Mar 11 '22 14:03 benhutton