Ben Frankel comments

Results 109 comments of


                                            Ben Frankel

Enter key treated as character E when `Window::prevent_default_event_handling` is `false`

The winit issue says it's fixed. Can this be closed?

Bevy hot asset reloader decides to scan every file in project directory

Embedded assets are stored in the `src/` directory, so maybe it is related to `embedded_watcher` specifically?

Can not load 3D examples on the website

I see this error on https://janhohenheim.itch.io/bike-game. - **OS:** Arch Linux x86-64 v6.9.9-arch1-1 - **Browser:** Firefox v128.0 - **WM:** i3 v4.23 - **GPU:** `AdapterInfo { name: "AMD Radeon RX 570 Series...

Should EntityCommands consume self?

Another example where this is awkward is in the implementation of `Commands::spawn`: https://github.com/bevyengine/bevy/blob/35fb54fa499074112a9e0391cab7583a14698209/crates/bevy_ecs/src/system/commands/mod.rs#L366-L370 Taking `self` instead of `&mut self`, this would instead be: ```rust pub fn spawn(&mut self, bundle: T)...

Require a `crate` field for every asset that is a crate

Current status: - Some crates in Bevy Assets have not been released on `crates.io`, so they still have no `crate = "..."` field. Every other crate now has a `crate`...

Question: How should these crates be handled?

This is not explicitly including the crates that are _very old_ and haven't been updated. Sorting by latest supported Bevy version will help with those cases (https://github.com/bevyengine/bevy-assets/issues/297).

Question: How should these crates be handled?

The "multiple crates" assets are fine of course. I marked them down to note that I had to pick just one of their multiple crates for the `crate` field.

Question: How should these crates be handled?

My take: IMO the crates with no `crates.io` release should never have been added to Bevy Assets in the first place. It feels like there should be some minimum bar...

Perhaps support cargo-generate

I'm not sure how `cargo-generate` works, but something like this would be useful. I recently added a shell script for this in my jam template: https://github.com/benfrankel/bevy_jam_template/blob/main/create.sh.

Depend on bevy's subcrates directly instead of as `bevy` features

Well.. I still think this is undesirable behavior but that seems to be controversial on the bevy discord. I'm willing to write a PR for this if wanted, but otherwise...