Ben Frankel comments

Results 109 comments of


                                            Ben Frankel

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

> Few more thoughts: > > The `NextState` force flag idea won't work with cases like: > > ```rust > ... > ``` > > which _could_ be the intended...

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

I don't think setting the state to `Foo` should be fully ignored if the current state is `Foo`. There was a logical intention for the next state to be `Foo`,...

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

> The Idea of removing the verification and let the user verifying themselves if they are trying to change something to the same state would probably be the simplest and...

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

> What if this happened due to system order ambiguity, then it's an additional thing to worry about If you have a race condition / ambiguity between systems that set...

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

Made a PR for the system param approach, which I prefer. I'm leaving the `NextState::set_forced` PR open for now. Names are all bikesheddable, I didn't think too hard about them.

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

Until this is fixed, the easiest workaround is to add a `RestartFoo` state and a system upon entering `RestartFoo` to set the next state to `Foo`. This introduces a 1...

Need the OnEnter() and OnExit() to be run even if when transitioning to and from the same state.

This is fixed in my 3rd-party crate [pyri_state](https://github.com/benfrankel/pyri_state). I was unable to get any fix upstreamed unfortunately after _a lot of discussion_, because there's more than one way to implement...

Trait fn returning `impl Fn()` cannot be used as a system when called from generic type

Workaround: ```rust trait Foo { fn foo() -> BoxedSystem { Box::new(IntoSystem::into_system(|| {})) } } ```

Trait fn returning `impl Fn()` cannot be used as a system when called from generic type

This bug applies to run conditions as well, but `BoxedCondition` is not a proper workaround because it doesn't `impl Condition`. You have to use `.run_if_dyn` instead of `.run_if`, but `.run_if_dyn`...

Trait fn returning `impl Fn()` cannot be used as a system when called from generic type

Interesting. That works. I guess this isn't a bug in Rust or Bevy, but it is surprising.