Jan Beneš
Jan Beneš
I don't know what is the state of this issue now but having support for this would be great 👍
@amritkumarj Please make CI pass
Hello @drshrey, how is it going with this bridge? 😊
> Finishing up the final unit test and finalise logic today, will have it out for the first set of reviews eod PT! Great to hear 👍 BTW can you...
@drshrey It seems that the contracts don't compile. Can you please fix that along with the linting errors? Running `yarn lint` returns the following: Thank you 👍
> The circle test failed on the foundry tests but I just checked and it wasn't my tests that made it fail so mine are good to go as far...
@ndebrouwer We've updated `sendDefiRollup(...)` function and now it returns the same values as bridge's `convert(...)` function. Should make it much easier to write the E2E tests.
Hello @ndebrouwer, > Also: in response to me asking about swapping on my LP bridge, you said "Hello, this should be handled by the bridge". Just to be clear, you...
@haowang0402 before sending it for a review again please address all my comments and rebase onto master. Thank you
Hello @haowang0402 , this PR contains changes unrelated to Notional. Please try rebasing onto master and force pushing to this branch. See [this article](https://blog.verslu.is/git/git-rebase/) for how to do it. If...