aztec-connect-bridges icon indicating copy to clipboard operation
aztec-connect-bridges copied to clipboard

Published 20 hours ago • verified publisher icon AztecProtocol

Notional Bridge

Open haowang0402 opened this issue 2 years ago • 3 comments

Checklist:

  • [ ] I have reviewed my diff in github, line by line.
  • [ ] Every change is related to the PR description.
  • [ ] There are no unexpected formatting changes, or superfluous debug logs.
  • [ ] The branch has been rebased against the head of its merge target.
  • [ ] I'm happy for the PR to be merged at the reviewers next convenience.
  • [ ] NatSpec documentation of all the non-test functions is present and is complete.
  • [ ] Continuous integration (CI) passes.

haowang0402 avatar Jul 24 '22 15:07 haowang0402

@haowang0402 before sending it for a review again please address all my comments and rebase onto master. Thank you

benesjan avatar Aug 23 '22 10:08 benesjan

Hello @haowang0402 , this PR contains changes unrelated to Notional. Please try rebasing onto master and force pushing to this branch. See this article for how to do it. If you have issues with that just copy the files to a new branch and submit a new PR. Please follow the PR checklist. image

benesjan avatar Aug 30 '22 07:08 benesjan

Hi, I just rebased to the master branch. Could you please take another look?

haowang0402 avatar Aug 31 '22 13:08 haowang0402

Grant closed

benesjan avatar Nov 11 '22 21:11 benesjan