bendk

Results 297 comments of bendk

This tool generates JSON files, which devs can then upload to the Grafana import page. Here's examples from the current config: - [Sync team dashboard](https://yardstick.mozilla.org/d/sync-main/sync). - [DISCO team demo dashboard](https://yardstick.mozilla.org/d/disco-main/disco)...

I'm definitely for moving away from JNA and towards JNI. I'm just trying to figure out how to break this up into chunks. JNI has some extra complexity, namely we...

> It seems like this -- only pointers and potentially bit-packing -- doesn't lend itself to a direct JNI future. I should have addressed this in my last comment, but...

One piece of complexity this doesn't avoid is callback interfaces. For those, we're still going to need to use JNA to adapt JVM methods to be C functions. I don't...

Another tricky part are UniFFI items created by macro expansion. I don't think we can ever get this working with syn, but maybe RA-based code could do it? I know...

How do others feel about the reliability of using rust-analyzer? I'm slightly worried because we've hit issues with RA crashing in the UniFFI code, it would be really annoying if...

> Have you considered having the macros generate a text metadata file alongside the code? That was actually how it was first implemented. The issue there was that we weren't...

I just checked the status in moz-central and it looks like [they're working to bump the MSRV version right now](https://bugzilla.mozilla.org/show_bug.cgi?id=1986626). I'd expect a fix in the next few weeks, but...

> In my mind the biggest benefit is actually that using types from a crate with builtin UniFFI support doesn't require 'importing' the trait impls at all with this, regardless...

> I'm twice confused though :) > > > doesn't require 'importing' the trait impls at all with this > > That sounds great too, but I don't know what...