bendk
bendk
How would this work when the record was passed back from the foreign language -> Rust? At that point, we'd need to fill in some value for the field. This...
> Its Default value sounds like the reasonable approach. > In my opinion this should be used for Rust -> FFI, not backwards Those 2 approaches are not exactly compatible...
> `trait KeyStore { ... }` - there would be a few options for what this should do, but it could start with just `get_key()`. > > The public API...
I agree with this. The current system is based on the general lift/lower system, where we assume that any Rust type can be lowered and the only error possibility is...
Of all the changes I'm suggesting, this is the one that I'm most torn on. On one hand, I think this would be really useful for the JS bindings. On...
This looks like just the behavior outlined in https://mozilla.github.io/uniffi-rs/latest/types/custom_types.html#error-handling-during-conversion. You need to make the Rust function return an error and implement a conversion into that error type, or else you'll...
I totally agree. I think this is not so much of a code issue, but finding a solution that balances all the factors here: convenience, discoverability, flexibility etc. I don't...
This new API is still a WIP, but I think we still could merge this since no consumers are using it yet. I tested it with the `cargo rs` CLI...
> We certainly don't need all the metadata cargo gives us, but we do need what we actually use. I think the first step is identifying what this is. Based...
> I support the idea, but this new dependency is likely to be a problem for us - even without the new crate duplicates this introduces. I wonder if we...