application-services icon indicating copy to clipboard operation
application-services copied to clipboard
verified publisher icon mozilla

Duplicate login in update

Open bendk opened this issue 3 years ago • 1 comments

A few months ago we had a Fenix Crasher when it was trying to update a login when there was a duplicate in the database. We addressed this by preventing the crash and logging instead on app-services side (#4648).

Looking through the sentry today I saw multiple reports of the duplicate login error which makes me think we should fix the underlying issue. Looking through the report data I saw:

  • Multiple users affected
  • Each time has_mirror was true, so it seems like this stems from the sync code being able to produce a duplicate login.

┆Issue is synchronized with this Jira Task

bendk avatar Jul 28 '22 18:07 bendk

My first attempt to narrow this down is checking if the login has form_action_origin or http_realm set. My hunch is that it's one kind or another that generates the duplicates.

bendk avatar Jul 29 '22 14:07 bendk

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866372

Change performed by the Move to Bugzilla add-on.

mhammond avatar Nov 23 '23 22:11 mhammond