bendk

This PR doesn't have any breaking changes (I think), but there are a couple that could be useful: - Change the variants of `PlacesError` so that they are more likely...

Just updated this one and pushed a couple more commits. The new commits rename some errors and combine some variants in a way that I think makes more sense. Is...

> I'm actually mildly in favour of splitting this back out into multiple PRs. Makes sense to me. I moved the breaking parts into #5166. I guess the last thing...

@mhammond I think all that's left is the `thiserror` question, what do you think about it?

For that second part, I think we should try one more time to get a good interruption system. What if `PlacesDb` stored an `AtomicU32` that stored the interruption state? `0`...

So seems like we're leaning towards not interrupting. What if we updated the result of the operation to give you some metrics that could be useful for both scheduling purposes...

> What is the target size in this case? Whatever value you pass in to us. Desktop uses 75 MiB which seems like a good starting point (https://searchfox.org/mozilla-central/source/toolkit/components/places/PlacesExpiration.sys.mjs#47)

One slight tweak after writing this code is that I think we should metrics on time taken, but not return it as part of the metrics struct. The reason is...

AFAICT all the app-services code is ready now that #5123 has been merged. Closing this one.

I added Swift support and also support for serializing error strings for unexpected errors. I'm thinking this is pretty much what we want. There's one last issue. This change requires...