Andrei-Florin Bencsik comments

Results 6 comments of


                                            Andrei-Florin Bencsik

Create Docker containers for easy ARM cross-compilation

Hey, how about we start with a docker container for ubuntu:latest (20.04 as I write this)? It would be useful to run tests locally without the need for g++-8 -...

Add unit tests for `ModLibrary`

> and instead allow injecting a fake list of directories for testing. How exactly to do that would be part of this work, as there are various options. I haven't...

[WIP] replace mbgl::variant with std::variant

> Looks great overall but I would like to know why the `Overload` helper is needed. the API for `std::visit` is quite different from the one in `mapbox::variant::match`, in that...

[WIP] replace mbgl::variant with std::variant

Hi! I've been working on this on and off but have struggled with a couple things in the public headers (notably changes involving some stuff that mbgl::variant and std::variant handle...

[WIP] replace mbgl::variant with std::variant

I also have 0 idea what this wants from me: `/platform/macos/src/MLNMapViewDelegate.h:88:63: error: expected a type - (BOOL)mapView:(MLNMapView *)mapView shouldChangeFromCamera:(MLNMapCamera *)oldCamera toCamera:(MLNMapCamera *)newCamera; ^ ./platform/macos/src/MLNMapViewDelegate.h:88:98: error: expected a type - (BOOL)mapView:(MLNMapView...

work around GCC 6~11 ADL bug

is there any news on this one?