googletest icon indicating copy to clipboard operation
googletest copied to clipboard

work around GCC 6~11 ADL bug

Open pgroke-dt opened this issue 2 years ago • 5 comments

see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51577 ADL seems to work properly when we do the SFINAE check via the return type, but not when using a dummy template parameter

fix #3992

pgroke-dt avatar Aug 31 '22 14:08 pgroke-dt

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 31 '22 14:08 google-cla[bot]

Generally looks good. Please sign the CLA, and we'll get this merged.

asoffer avatar Sep 14 '22 14:09 asoffer

The CLA should be signed, but somehow it still doesn't work. The issue is being discussed here: https://github.com/google/closure-compiler/pull/3988 In the meantime I will update the PR to use trailing return type as you requested.

pgroke-dt avatar Sep 14 '22 14:09 pgroke-dt

@asoffer Sorry for taking so long, but the CLA check is finally green now.

pgroke-dt avatar Oct 04 '22 11:10 pgroke-dt

@asoffer Hi. I made the changes you requested and the CLA check is green. Is there anything blocking us from moving forward with this?

pgroke-dt avatar Nov 17 '22 12:11 pgroke-dt

@asoffer @derekmauro I'd really like to proceed with this. Please let me know if there's something I need to do before this can be merged.

pgroke-dt avatar Jan 12 '23 12:01 pgroke-dt

@asoffer @derekmauro @dinord could someone of you please look into this? This bug is what is keeping me from moving to following HEAD of googletest in my projects as they fail to compile :eyes:

Krzmbrzl avatar Feb 24 '23 08:02 Krzmbrzl

is there any news on this one?

bencsikandrei avatar Apr 06 '23 09:04 bencsikandrei

Unfortunately not and I have the feeling that my pings to @asoffer @derekmauro and @dinord didn't get through :shrug:

Krzmbrzl avatar Apr 12 '23 14:04 Krzmbrzl