Benoit Bovy

Sorry @kmuehlbauer not sure what is causing the different behavior here, although I haven't inspected further the reindex vs. sortby code.

S2geometry provides `Encoder` and `Decoder` objects as well as `Encode()` and `Decode()` methods from most of its data types (point, polyline, polygon) so we might be able to just reuse...

Actually, I think we could already access `Encode()` and `Decode()` via `s2geography::Geography::Shape()`.

https://github.com/paleolimbot/s2geography/pull/40 is now merged so adding support for pickle should be easier. That s2geography PR also added the `GeographyKind` enum tag, which will allow us to clean up some parts...

Sorry for not having replied yet! I agree it would be nice indeed to return distances in other units. Best I think would be via options `units` and `radius` added...

Yes I've been working further on this (last updates not uploaded yet) but that might be too much of a change indeed. I'll restrict this PR to the refactoring of...

> For points, I would keep the vectorized function you already have, since in this case it is quite simple, I think? (and you already have that) Yes. For a...

Thanks for the review comments @jorisvandenbossche. I also have been thinking about the naming... Likewise I'm still not fully convinced myself and I don't have strong opinions either. We could...

This is getting close. I'd just like to investigate the segfault when creating nested geography collections before making this PR ready (EDIT: fixed segfault). A few other comments that we...

> I would maybe lean towards GeographyType::GeometryCollection, although that is certainly odd as well .. > Another case where this occurs is in the spherely.geography_collection(..) constructor. For that case, we...