Benoit Bovy

Results 452 comments of Benoit Bovy

> The current behaviour of Dataset.from_dataframe where it always unstacks feels wrong to me. Agreed. I guess that's because it has been there before any multi-index support in Xarray? I'm...

Yes we certainly can! We can also have both and keep `dim` afterwards, assuming that a MultiIndex rarely has its `.name` set (that's why I added a `dim` argument in...

> was there any progress on allowing .sel to work with coords? IIRC there were some plans to allow indexes on coords beyond those named the same as a dimension....

> Or does 'the MultiIndex is added to the Dataset with all its levels as 1D coordinates of dimension "x"' mean that we would still have a MultiIndex, and the...

> We'll have a deprecation warning for .from_dataframe without a dim arg The dim arg will cause it to not unstack? Either that (warning without a dim arg *and* when...

I opened #8140 to continue the discussion about Dataset.from_dataframe.

> I think we're in broad consensus on the goals. Is that right? :) Yes I think so. Well, almost :). Using `xr.Dataset(df)` will become more difficult to support especially...

FWIW, I had the same warning issued from a file with `from __future__ import annotations`. Upgrading Python from 3.10 to 3.11 in my environment (with same versions of sphinx and...

> For convenience we might also choose to auto-convert indexes for Xarray built-in index types only Good thing is that changing the behavior implemented in #163 (auto-convert all indexes ->...

Yes a wrapper method like `.pint.set_xindex()` would be useful. I don't think we would need to dequantify the coordinate(s) first, having unindexed but quantified coordinates seems ok to me and...