Benoit Bovy

Results 452 comments of Benoit Bovy

Yes I will do all of that before marking this PR as ready. > Does the xarray pin need to be updated? Likely for the tests yes. Since this is...

> How should we bring in xproj to handle CRS here? A followup PR? Yes, a separate PR will be easier I think. Interoperability between xproj and rioxarray would likely...

About the performance of the (static html) reprs, I'm afraid there's no way around truncating them for large trees. There are much more possibilities with dynamic (widget) reprs supporting bi-directional...

Thanks for pinging me @scottyhq. @drammock -- Although I haven't been closely following the changes in the Xarray's repr CSS lately (especially those related to themes), most of the useful...

For Xarray's documentation it should be fixed with the workaround introduced in https://github.com/pydata/xarray/pull/10353. However, it would still be nice if a special case could be introduced here (could simply be...

> I've been out of the loop of discussions recently (and less recently...) No worries! There's a more context in https://github.com/pydata/xarray/issues/6293#issuecomment-1259228475 and in https://github.com/pydata/xarray/issues/6392#issuecomment-1080738079. > Is there a downside to...

@dcherian ideally `GroupBy._infer_concat_args()` would return a `xr.Coordinates` object that contains both the coordinate(s) and their (multi-)index to assign to the result (combined) object. The goal is to avoid calling `create_default_index_implicit(coord)`...

> I'm wondering whether we can still do something reasonable when a MultiIndex is passed in, since that's quite common IME, and it's common with folks who want to do...

Yes I guess more generally it all depends on whether we see an Xarray Dataset as a kind of multi-dimensional dataframe or as a mapping of n-dimensional arrays with labels....

@max-sixty your questions and thoughts are very much appreciated, please continue to do it! While there seems to me that there is a broad agreement about deprecating special multi-index behavior...