Benjamin Trenkle comments

Results 95 comments of


                                            Benjamin Trenkle

[5.1] Switching Folder::makeSafe() to framework version

Thanks

[5.1] Fix content history diff error

Thx

[5.1] Switching Folder::files() to framework version

Thx

Dark mode for Joomla 5.1

Closed in favour of https://github.com/joomla/joomla-cms/pull/42986

[5.1] Unused imports

Thx

[5.1] Replace hard coded img element by JLayout joomla.html.image and DRY

Thanks

[5.x] Template color scheme configuration

Hey @Fedik , looks good. Do you see also an option to add the user parameters as an extra layer, so a user can define their preferences?

[5.1] Schema.org: Fix error when menu item doesn't exist

I think tis is the wrong approach, just because there is no menu (not sure if this ever should happen...but that's another topic) you should not skip all the output....

[5.1] Schema.org: Fix error when menu item doesn't exist

If it's a broken page, then throw an error? Make a redirect? Make it no-index?

[5.1] Schema.org: Fix error when menu item doesn't exist

Removed RTC, see: https://github.com/joomla/joomla-cms/pull/42662#issuecomment-1898072839 Just fix line 319 + 323 instead of throwing everything away