Benjamin Trenkle
Benjamin Trenkle
> @N6REJ its because one of the rules in svgsanitize is to mark a space as an error. We could easily allow spaces just as we allow comments although I...
Problem is: https://github.com/darylldoyle/svg-sanitizer/blob/master/src/Sanitizer.php#L369 Change: ``` $attrName = $element->attributes->item($x)->name ``` to ``` $attrName = $element->attributes->item($x)->nodeName; ``` it solves the problem, I'm unsure about the side effects...
I think the position of publish up/down is wrong at all...we should stick with out standard we have in e.g. articles and have it in the correct follow up tabs....
Like I said, it should be streamlined with the other implementation we have in core already
> > > Is `thump_path` always the same as the `url`? If so then remove it in the Media manager Api, but I think that thump is for a thumbnail...
I think this feature would be a nice addition, but I have to agree, it shouldn't be a modal. I think this should me incooperated into a bigger improvement project...
Thank you @vlaucht for your PR
See: https://github.com/joomla/joomla-cms/pull/37537#issuecomment-1096275706
We need for sure also a server side validation for this (e.g. in the models validate method)