Benjamin Trenkle comments

Results 95 comments of


                                            Benjamin Trenkle

Allow onValidateContact plugin to show error message

Hey @beefcakefu very cool addition :+1: Thank you for your contribution. I moved it to the 4.2 branch, as it's not really a bug fix but an enhancement. So it...

[4.2] [GSoC 21] Cookie Manager

> This would be best Git Squashed before committing :) > https://www.git-tower.com/learn/git/faq/git-squash/ That's normally what we do, so yes agree 😉

[6.0] Add a global master language for Multilingual Associations

I really like the idea of a master language and this whole PR is an awesome piece of code. Thanks for that! But now the "but": I would really like...

[5.2] Separate activation from resetToken

@Arpit-24 I've updated the branche to 4.1, because I think the idea behind this PR is not bad. Probabla you could clean up the PR (like using DateTime classes for...

[4.0] Prevent finding no stemmer in finder when language is "*"

@Hackwar could you please check here and give your feedback?

[4.0] Prevent finding no stemmer in finder when language is "*"

It was not the intention to prevent the exception but to find a stemmer if possible. But I have no feelings if this improvement should be merge or not.

[4.0] Fixing #__assets table

Thx

[4.1] Fix Content - Email Cloaking removes CSS from Link

For me this solves a lot of problems but the first example is broken. It should NOT display the email address at all, even though there is a link around....

[4.1] Fix Content - Email Cloaking removes CSS from Link

@LukasHH would you mind looking into this PR and fix the last issue?

[4.2] Smart Search Sorting Drop-Down

Revert RTC as it needs some reworkThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35993.