Martin Fox

Results 119 comments of Martin Fox

> Thinking out loud for a moment: wouldn't it be better to use a kind of EventFilter specifically for the shortcuts, before the normal dispatching happens? I think I see...

I'm marking this PR as draft for now. Turns out we're relying on double-processing of key events to make IM's work. macOS sends a navigation key to us via performKeyEquivalent....

> is there a compelling reason we are not using Event::isConsumed? As detailed in the discussion of PR #1523 the `isConsumed` flag doesn't work because the consumed event is a...

Taking this out of Draft. To ensure consistent handling of the IM both `keyDown:` and `performKeyEquivalent:` use the same routine. There's a check to ensure that the same event doesn't...

> so here is an unrelated question - if we assume that the controls should only consume the event if it effected a change in said control, what should command-A...

When the window is restored glass calls notifySize with RESTORED and then notifyRepaint with valid dimensions. Why is the repaint being dropped?

> Can you give me a bit more detail what you mean here? I suspect it might be related to the size not actually changing, and so a size update...

I just verified that this PR does not fix the original issue on the Mac. Note: I could not reproduce the bug on my Mac 15.3.2 M2 Max using the...

Adding `entireSceneNeedsRepaint` fixes this on the Mac.