Martin Fox

Results 74 comments of Martin Fox

Thanks for catching this, I should have investigated dead keys in more detail earlier. The test case code should exclude dead keys since they're not eligible as shortcuts on Windows....

Marking this as DRAFT since this code could be superseded by #694. The review cycles weren't wasted since similar code will re-appear in the PR for [JDK-8278938](https://bugs.openjdk.java.net/browse/JDK-8278938) which fixes the...

1. On Windows and Linux the library can draw on child windows, you just have to create a custom Surface class which hands over the child window in the NativeHandle...

@LukasBanana I'm glad you approve. Taking just the `Application` interface is a little involved on the Mac. To make it work there needs to be an `NSResponder` handling events. At...

Creating a default surface is problematic when all you have is a resolution in hand. The old code would create a `Window` of that size (interpreting the resolution not as...

The calls that enable features are piecemeal and so it shouldn't be too much trouble to surround them with appropriate version guards. The problem area is the loop that calls...

@andy-goryachev-oracle This bug is Linux-specific and this PR only fixes Linux. It's still worth testing on Mac and Windows just to verify that they're not affected. Those platforms also have...

@andy-goryachev-oracle My highest priorities are #425 (Mac) and the Java code in this PR. I'll get it switched over to Windows as soon as possible so we have a complete...

@andy-goryachev-oracle My apologies, I really should have cleaned this PR up weeks ago when the bridgekeeper bot flagged it. The portion of this PR that is platform-agnostic was also submitted...

This PR appears to be starting with an undecorated stage and then creating all of the standard decorations including the drop shadows and resize corners and edges. Are JavaFX developers...