Martin Fox

Results 74 comments of Martin Fox

I've attached a text document which details which Java key codes are lost and gained for each keyboard layout compared to the pre-PR code. It also flags some potential trouble...

The question was raised earlier why we can’t just generate the key code based on the typed character. That’s basically the Swing approach and I could evaluate what it would...

I would like to get this review restarted. Sorry I let it lapse for so long. I was asked to evaluate a Swing-style solution which determines the Java key code...

Is there some reason you would prefer a Swing-style implementation over the approach I submitted in this PR? The Swing code breaks down if an accelerator calls for the Option...

@tomsontom I've added the Swing-style code as WIP PR #519. There are comments in the PR that probably should be in the code but I wanted to reduce the code...

@johanvos I've attached my test app to this comment. The test I was referring to is invoked using the `A-Z Test` button down at the bottom. The test just sends...

I’m not sure how to approach regression testing. MacOS 11 ships with 189 keyboard layouts and this PR changes the key assignments for 62 of them. On each layout there...

I can't build this branch anymore, something related to compiling CCTaskGroovy. I think I need to merge or rebase to the latest version of master. Which is preferred, merge or...

Let me start by saying that I already have two small changes to make to this PR. One is a fix for a bug in the Robot code. The other...

I’ve updated the PR with three bug fixes that were in my queue. Sorry for not getting them in earlier. GetGlassKey (used by the Robot) - The table only covers...